From a3af7bd0ec78d87edde6e15d42da5f657e457db9 Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Thu, 19 Sep 2024 16:27:11 -0400 Subject: [PATCH] Use simpler (but equivalent) logic Co-authored-by: Curtis Vogt --- .github/workflows/pr_checks.yml | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/.github/workflows/pr_checks.yml b/.github/workflows/pr_checks.yml index a9ff911..3ee8cff 100644 --- a/.github/workflows/pr_checks.yml +++ b/.github/workflows/pr_checks.yml @@ -30,15 +30,8 @@ jobs: echo npm-run-test: ${{ needs.npm-run-test.result }} echo make-targets: ${{ needs.make-targets.result }} echo stalecheck-npm-install: ${{ needs.stalecheck-npm-install.result }} - # The last line must NOT end with || - # All other lines MUST end with || - run: exit 1 - if: | - (needs.checked-in-files.result != 'success') || - (needs.build.result != 'success') || - (needs.npm-run-test.result != 'success') || - (needs.make-targets.result != 'success') || - (needs.stalecheck-npm-install.result != 'success') + if: ${{ !contains(needs.*.result, 'failure') || !contains(needs.*.result, 'cancelled') || !contains(needs.*.result, 'skipped') }} checked-in-files: timeout-minutes: 30 runs-on: ubuntu-latest