Add benchmark

fixes #35

.github/workflows/example-builds-nightly.yml

@@ -35,5 +35,5 @@ jobs:
         with:
           version: ${{ matrix.julia-version }}
           arch: ${{ matrix.julia-arch }}
-          show-versioninfo: 'true'
       - run: julia --version
+      - run: julia --compile=min -O0 -e 'import InteractiveUtils; InteractiveUtils.versioninfo()'

.github/workflows/example-builds.yml

@@ -34,5 +34,5 @@ jobs:
         with:
           version: ${{ matrix.julia-version }}
           arch: ${{ matrix.julia-arch }}
-          show-versioninfo: 'true'
       - run: julia --version
+      - run: julia --compile=min -O0 -e 'import InteractiveUtils; InteractiveUtils.versioninfo()'

.github/workflows/windows-tests.yml

@@ -0,0 +1,44 @@
+name: Windows Benchmark
+
+on: [push]
+
+jobs:
+  installer:
+    name: Installer
+    runs-on: windows-latest
+
+    steps:
+      - name: Download
+        run: curl -O https://julialang-s3.julialang.org/bin/winnt/x64/1.5/julia-1.5.3-win64.exe
+        shell: bash
+
+      - name: Install
+        run: |
+          Start-Process -FilePath julia-1.5.3-win64.exe -ArgumentList "/SILENT /dir=C:\Julia" -NoNewWindow -Wait
+      
+      - name: Add to path
+        run: |
+          echo "C:\Julia\bin" >> $GITHUB_PATH
+        shell: bash
+      
+      - run: julia --version
+  
+  archive:
+    name: Archive
+    runs-on: windows-latest
+
+    steps:
+      - name: Download
+        run: curl -O https://julialang-s3.julialang.org/bin/winnt/x64/1.5/julia-1.5.3-win64.zip
+        shell: bash
+
+      - name: Install
+        run: |
+          [System.IO.Compression.ZipFile]::ExtractToDirectory('julia-1.5.3-win64.zip', 'C:\Julia')
+      
+      - name: Add to path
+        run: |
+          echo "C:\Julia\julia-1.5.3\bin" >> $GITHUB_PATH
+        shell: bash
+      
+      - run: julia --version

.gitignore

@@ -1,3 +1,3 @@
 node_modules/
 __tests__/runner/*
-!dist/
+dist/

README.md

@@ -43,8 +43,18 @@ This action sets up a Julia environment for use in actions by downloading a spec
     # Default: x64
     arch: ''
 
-    # If true, display the output of InteractiveUtils.versioninfo() after installing.
+    # Set the display setting for printing InteractiveUtils.versioninfo() after installing.
-    # See "versioninfo" below for example usage.
+    #
+    # Starting Julia and running InteractiveUtils.versioninfo() takes a significant amount of time (1s or ~10% of the total build time in testing),
+    # so you may not want to run it in every build, in particular on paid runners, as this cost will add up quickly.
+    #
+    # See "versioninfo" below for example usage and further explanations.
+    #
+    # Supported values: true | false | never
+    #
+    # true: Always print versioninfo
+    # false: Only print versioninfo for nightly Julia
+    # never: Never print versioninfo
     #
     # Default: false
     show-versioninfo: ''
@@ -179,18 +189,13 @@ jobs:
 
 ### versioninfo
 
-By default, only a brief version identifier is printed in the run log. You can display the full `versioninfo` by adding `show-versioninfo`.
+By default, only the output of `julia --version` is printed as verification that Julia has been installed for stable versions of Julia.
-Here's an example that prints this information just for `nightly`:
+`InteractiveUtils.versioninfo()` is run by default for nightly builds.
 
-```yaml
+Starting Julia and printing the full versioninfo takes a significant amount of time (1s or ~10% of the total build time in testing), so you may not want to run it in every build, in particular on paid runners as this cost will add up quickly.
-    - uses: julia-actions/setup-julia@v1
+However, `julia --version` does not provide sufficient information to know which commit a nightly binary was built from, therefore it is useful to show the full versioninfo on nightly builds regardless.
-      with:
+
-        version: ${{ matrix.version }}
+You can override this behaviour by changing the input to `never` if you never want to run `InteractiveUtils.versioninfo()` or to `true` if you always want to run `InteractiveUtils.versioninfo()`, even on stable Julia builds.
-        arch: ${{ matrix.arch }}
-        show-versioninfo: ${{ matrix.version == 'nightly' }}
- ```
- 
-You use `'true'` if you want it printed for all Julia versions.
 
 ## Versioning
 

lib/installer.js

@@ -22,6 +22,7 @@ const crypto = __importStar(require("crypto"));
 const fs = __importStar(require("fs"));
 const os = __importStar(require("os"));
 const path = __importStar(require("path"));
+const retry = require("async-retry");
 const semver = __importStar(require("semver"));
 // Translations between actions input and Julia arch names
 const osMap = {
@@ -59,7 +60,15 @@ function calculateChecksum(file) {
  */
 function getJuliaVersionInfo() {
     return __awaiter(this, void 0, void 0, function* () {
-        const versionsFile = yield tc.downloadTool('https://julialang-s3.julialang.org/bin/versions.json');
+        // Occasionally the connection is reset for unknown reasons
+        // In those cases, retry the download
+        const versionsFile = yield retry((bail) => __awaiter(this, void 0, void 0, function* () {
+            return yield tc.downloadTool('https://julialang-s3.julialang.org/bin/versions.json');
+        }), {
+            onRetry: (err) => {
+                core.debug(`Download of versions.json failed, trying again. Error: ${err}`);
+            }
+        });
         return JSON.parse(fs.readFileSync(versionsFile).toString());
     });
 }
@@ -146,7 +155,15 @@ function installJulia(versionInfo, version, arch) {
         const fileInfo = getFileInfo(versionInfo, version, arch);
         const downloadURL = getDownloadURL(fileInfo, version, arch);
         core.debug(`downloading Julia from ${downloadURL}`);
-        const juliaDownloadPath = yield tc.downloadTool(downloadURL);
+        // Occasionally the connection is reset for unknown reasons
+        // In those cases, retry the download
+        const juliaDownloadPath = yield retry((bail) => __awaiter(this, void 0, void 0, function* () {
+            return yield tc.downloadTool(downloadURL);
+        }), {
+            onRetry: (err) => {
+                core.debug(`Download of ${downloadURL} failed, trying again. Error: ${err}`);
+            }
+        });
         // Verify checksum
         if (!version.endsWith('nightly')) {
             const checkSum = yield calculateChecksum(juliaDownloadPath);
@@ -184,3 +201,40 @@ function installJulia(versionInfo, version, arch) {
     });
 }
 exports.installJulia = installJulia;
+/**
+ * Test if Julia has been installed and print the version.
+ *
+ * true => always show versioninfo
+ * false => only show on nightlies
+ * never => never show it anywhere
+ *
+ * @param showVersionInfoInput
+ */
+function showVersionInfo(showVersionInfoInput, version) {
+    return __awaiter(this, void 0, void 0, function* () {
+        // --compile=min -O0 reduces the time from ~1.8-1.9s to ~0.8-0.9s
+        let exitCode;
+        switch (showVersionInfoInput) {
+            case 'true':
+                exitCode = yield exec.exec('julia', ['--compile=min', '-O0', '-e', 'using InteractiveUtils; versioninfo()']);
+                break;
+            case 'false':
+                if (version.endsWith('nightly')) {
+                    exitCode = yield exec.exec('julia', ['--compile=min', '-O0', '-e', 'using InteractiveUtils; versioninfo()']);
+                }
+                else {
+                    exitCode = yield exec.exec('julia', ['--version']);
+                }
+                break;
+            case 'never':
+                exitCode = yield exec.exec('julia', ['--version']);
+                break;
+            default:
+                throw new Error(`${showVersionInfoInput} is not a valid value for show-versioninfo. Supported values: true | false | never`);
+        }
+        if (exitCode !== 0) {
+            throw new Error(`Julia could not be installed properly. Exit code: ${exitCode}`);
+        }
+    });
+}
+exports.showVersionInfo = showVersionInfo;

lib/setup-julia.js

@@ -16,7 +16,6 @@ var __importStar = (this && this.__importStar) || function (mod) {
 };
 Object.defineProperty(exports, "__esModule", { value: true });
 const core = __importStar(require("@actions/core"));
-const exec = __importStar(require("@actions/exec"));
 const tc = __importStar(require("@actions/tool-cache"));
 const fs = __importStar(require("fs"));
 const https = __importStar(require("https"));
@@ -79,15 +78,8 @@ function run() {
             // Set output
             core.setOutput('julia-bindir', path.join(juliaPath, 'bin'));
             // Test if Julia has been installed and print the version
-            if (core.getInput('show-versioninfo') == 'true') {
+            const showVersionInfoInput = core.getInput('show-versioninfo');
-                // If enabled, show the full version info
+            yield installer.showVersionInfo(showVersionInfoInput, version);
-                // --compile=min -O0 reduces the time from ~1.8-1.9s to ~0.8-0.9s
-                exec.exec('julia', ['--compile=min', '-O0', '-e', 'using InteractiveUtils; versioninfo()']);
-            }
-            else {
-                // Otherwise only print julia --version to save time
-                exec.exec('julia', ['--version']);
-            }
         }
         catch (error) {
             core.setFailed(error.message);

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "setup-julia",
-  "version": "1.5.2",
+  "version": "1.6.0",
   "lockfileVersion": 1,
   "requires": true,
   "dependencies": {
@@ -1384,6 +1384,15 @@
         "@types/yargs": "^12.0.9"
       }
     },
+    "@types/async-retry": {
+      "version": "1.4.2",
+      "resolved": "https://registry.npmjs.org/@types/async-retry/-/async-retry-1.4.2.tgz",
+      "integrity": "sha512-GUDuJURF0YiJZ+CBjNQA0+vbP/VHlJbB0sFqkzsV7EcOPRfurVonXpXKAt3w8qIjM1TEzpz6hc6POocPvHOS3w==",
+      "dev": true,
+      "requires": {
+        "@types/retry": "*"
+      }
+    },
     "@types/babel__core": {
       "version": "7.1.6",
       "resolved": "https://registry.npmjs.org/@types/babel__core/-/babel__core-7.1.6.tgz",
@@ -1471,6 +1480,12 @@
       "integrity": "sha512-E6Zn0rffhgd130zbCbAr/JdXfXkoOUFAKNs/rF8qnafSJ8KYaA/j3oz7dcwal+lYjLA7xvdd5J4wdYpCTlP8+w==",
       "dev": true
     },
+    "@types/retry": {
+      "version": "0.12.0",
+      "resolved": "https://registry.npmjs.org/@types/retry/-/retry-0.12.0.tgz",
+      "integrity": "sha512-wWKOClTTiizcZhXnPY4wikVAwmdYHp8q6DmC+EJUzAMsycb7HB32Kh9RN4+0gExjmPmZSAQjgURXIGATPegAvA==",
+      "dev": true
+    },
     "@types/semver": {
       "version": "6.0.1",
       "resolved": "https://registry.npmjs.org/@types/semver/-/semver-6.0.1.tgz",
@@ -1643,6 +1658,14 @@
       "integrity": "sha512-csOlWGAcRFJaI6m+F2WKdnMKr4HhdhFVBk0H/QbJFMCr+uO2kwohwXQPxw/9OCxp05r5ghVBFSyioixx3gfkNQ==",
       "dev": true
     },
+    "async-retry": {
+      "version": "1.3.1",
+      "resolved": "https://registry.npmjs.org/async-retry/-/async-retry-1.3.1.tgz",
+      "integrity": "sha512-aiieFW/7h3hY0Bq5d+ktDBejxuwR78vRu9hDUdR8rNhSaQ29VzPL4AoIRG7D/c7tdenwOcKvgPM6tIxB3cB6HA==",
+      "requires": {
+        "retry": "0.12.0"
+      }
+    },
     "asynckit": {
       "version": "0.4.0",
       "resolved": "https://registry.npmjs.org/asynckit/-/asynckit-0.4.0.tgz",
@@ -6046,6 +6069,11 @@
       "integrity": "sha512-TTlYpa+OL+vMMNG24xSlQGEJ3B/RzEfUlLct7b5G/ytav+wPrplCpVMFuwzXbkecJrb6IYo1iFb0S9v37754mg==",
       "dev": true
     },
+    "retry": {
+      "version": "0.12.0",
+      "resolved": "https://registry.npmjs.org/retry/-/retry-0.12.0.tgz",
+      "integrity": "sha1-G0KmJmoh8HQh0bC1S33BZ7AcATs="
+    },
     "rimraf": {
       "version": "2.7.1",
       "resolved": "https://registry.npmjs.org/rimraf/-/rimraf-2.7.1.tgz",

package.json

@@ -1,6 +1,6 @@
 {
   "name": "setup-julia",
-  "version": "1.5.2",
+  "version": "1.6.0",
   "private": true,
   "description": "setup Julia action",
   "main": "lib/setup-julia.js",
@@ -25,9 +25,11 @@
     "@actions/exec": "^1.0.0",
     "@actions/io": "^1.0.0",
     "@actions/tool-cache": "^1.0.0",
+    "async-retry": "^1.3.1",
     "semver": "^6.3.0"
   },
   "devDependencies": {
+    "@types/async-retry": "^1.4.2",
     "@types/jest": "^24.0.13",
     "@types/node": "^12.12.7",
     "@types/semver": "^6.0.0",

src/installer.ts

@@ -6,6 +6,7 @@ import * as crypto from 'crypto'
 import * as fs from 'fs'
 import * as os from 'os'
 import * as path from 'path'
+import retry = require('async-retry')
 
 import * as semver from 'semver'
 
@@ -47,7 +48,15 @@ async function calculateChecksum(file: string): Promise<string> {
  * @returns The content of the downloaded versions.json file as object.
  */
 export async function getJuliaVersionInfo(): Promise<object> {
-    const versionsFile = await tc.downloadTool('https://julialang-s3.julialang.org/bin/versions.json')
+    // Occasionally the connection is reset for unknown reasons
+    // In those cases, retry the download
+    const versionsFile = await retry(async (bail: Function) => {
+        return await tc.downloadTool('https://julialang-s3.julialang.org/bin/versions.json')
+    }, {
+        onRetry: (err: Error) => {
+            core.debug(`Download of versions.json failed, trying again. Error: ${err}`)
+        }
+    })
 
     return JSON.parse(fs.readFileSync(versionsFile).toString())
 }
@@ -141,7 +150,17 @@ export async function installJulia(versionInfo, version: string, arch: string):
     const fileInfo = getFileInfo(versionInfo, version, arch)
     const downloadURL = getDownloadURL(fileInfo, version, arch)
     core.debug(`downloading Julia from ${downloadURL}`)
-    const juliaDownloadPath = await tc.downloadTool(downloadURL)
+
+    // Occasionally the connection is reset for unknown reasons
+    // In those cases, retry the download
+    const juliaDownloadPath = await retry(async (bail: Function) => {
+        return await tc.downloadTool(downloadURL)
+    }, {
+        onRetry: (err: Error) => {
+            core.debug(`Download of ${downloadURL} failed, trying again. Error: ${err}`)
+        }
+    })
+
 
     // Verify checksum
     if (!version.endsWith('nightly')) {
@@ -178,3 +197,42 @@ export async function installJulia(versionInfo, version: string, arch: string):
             throw new Error(`Platform ${osPlat} is not supported`)
     }
 }
+
+/**
+ * Test if Julia has been installed and print the version.
+ * 
+ * true => always show versioninfo
+ * false => only show on nightlies
+ * never => never show it anywhere
+ * 
+ * @param showVersionInfoInput 
+ */
+export async function showVersionInfo(showVersionInfoInput: string, version: string): Promise<void> {
+    // --compile=min -O0 reduces the time from ~1.8-1.9s to ~0.8-0.9s
+    let exitCode: number
+
+    switch (showVersionInfoInput) {
+        case 'true':
+            exitCode = await exec.exec('julia', ['--compile=min', '-O0', '-e', 'using InteractiveUtils; versioninfo()'])
+            break
+    
+        case 'false':
+            if (version.endsWith('nightly')) {
+                exitCode = await exec.exec('julia', ['--compile=min', '-O0', '-e', 'using InteractiveUtils; versioninfo()'])
+            } else {
+                exitCode = await exec.exec('julia', ['--version'])
+            }
+            break
+        
+        case 'never':
+            exitCode = await exec.exec('julia', ['--version'])
+            break
+
+        default:
+            throw new Error(`${showVersionInfoInput} is not a valid value for show-versioninfo. Supported values: true | false | never`)
+    }
+
+    if (exitCode !== 0) {
+        throw new Error(`Julia could not be installed properly. Exit code: ${exitCode}`)
+    }
+}

src/setup-julia.ts

@@ -75,14 +75,8 @@ async function run() {
         core.setOutput('julia-bindir', path.join(juliaPath, 'bin'))
 
         // Test if Julia has been installed and print the version
-        if (core.getInput('show-versioninfo') == 'true') {
+        const showVersionInfoInput = core.getInput('show-versioninfo')
-            // If enabled, show the full version info
+        await installer.showVersionInfo(showVersionInfoInput, version)
-            // --compile=min -O0 reduces the time from ~1.8-1.9s to ~0.8-0.9s
-            exec.exec('julia', ['--compile=min', '-O0', '-e', 'using InteractiveUtils; versioninfo()'])
-        } else {
-            // Otherwise only print julia --version to save time
-            exec.exec('julia', ['--version'])
-        }
     } catch (error) {
         core.setFailed(error.message)
     }