From 60dd89651a76797571a76bcebde621aa85f3b3ea Mon Sep 17 00:00:00 2001 From: Unai Martinez-Corral Date: Mon, 7 Nov 2022 22:14:53 +0000 Subject: [PATCH 01/12] with-post-step: use Node.js 16 instead of Node.js 12 https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/ --- with-post-step/action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/with-post-step/action.yml b/with-post-step/action.yml index 12aec6c..8e78a8c 100644 --- a/with-post-step/action.yml +++ b/with-post-step/action.yml @@ -37,6 +37,6 @@ inputs: default: POST runs: - using: 'node12' + using: 'node16' main: 'main.js' post: 'main.js' From 97fd0e59278300263d86ce71e1d45f295bf76cec Mon Sep 17 00:00:00 2001 From: Unai Martinez-Corral Date: Mon, 7 Nov 2022 22:32:30 +0000 Subject: [PATCH 02/12] with-post-step: save-state is deprecated https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ --- with-post-step/main.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/with-post-step/main.js b/with-post-step/main.js index 0fa6d9e..45caf18 100644 --- a/with-post-step/main.js +++ b/with-post-step/main.js @@ -25,6 +25,7 @@ * * https://github.com/actions/runner/issues/1478 * * ================================================================================================================== */ const { spawn } = require("child_process"); +const fs = require('fs'); function run(cmdline) { var args = cmdline.split(" "); @@ -41,6 +42,6 @@ const key = process.env.INPUT_KEY.toUpperCase(); if ( process.env[`STATE_${key}`] !== undefined ) { // Are we in the 'post' step? run(process.env.INPUT_POST); } else { // Otherwise, this is the main step - console.log(`::save-state name=${key}::true`); + fs.appendFileSync(process.env.GITHUB_STATE, `${key}=true`); run(process.env.INPUT_MAIN); } From 17bc23954a5b2519e79354c710d4fe20643bad33 Mon Sep 17 00:00:00 2001 From: Unai Martinez-Corral Date: Mon, 7 Nov 2022 22:26:56 +0000 Subject: [PATCH 03/12] set-output is deprecated https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ --- .github/workflows/CoverageCollection.yml | 8 ++++++-- .github/workflows/Parameters.yml | 9 +++++++-- .github/workflows/Release.yml | 8 +++++--- 3 files changed, 18 insertions(+), 7 deletions(-) diff --git a/.github/workflows/CoverageCollection.yml b/.github/workflows/CoverageCollection.yml index e4d9174..7161a39 100644 --- a/.github/workflows/CoverageCollection.yml +++ b/.github/workflows/CoverageCollection.yml @@ -79,6 +79,7 @@ jobs: id: getVariables shell: python run: | + from os import environ from pathlib import Path from tomli import load as tomli_load @@ -110,8 +111,11 @@ jobs: else: print(f"File '{coverageRCFile}' not found.") - print(f"::set-output name=coverage_report_html_directory::{htmlDirectory}") - print(f"::set-output name=coverage_report_xml::{xmlFile}") + with open(environ['GITHUB_OUTPUT'], 'a', encoding='utf-8') as gho: + gho.write(f"""\ + coverage_report_html_directory={htmlDirectory} + coverage_report_xml={xmlFile} + """) print(f"DEBUG:\n html={htmlDirectory}\n xml={xmlFile}") - name: Collect coverage diff --git a/.github/workflows/Parameters.yml b/.github/workflows/Parameters.yml index af22323..2db2c26 100644 --- a/.github/workflows/Parameters.yml +++ b/.github/workflows/Parameters.yml @@ -65,6 +65,8 @@ jobs: id: params shell: python run: | + from os import environ + name = '${{ inputs.name }}' params = { 'python_version': '${{ inputs.python_version }}', @@ -76,7 +78,9 @@ jobs: 'doc': f'{name}-doc', } } - print(f'::set-output name=params::{params!s}') + + with open(environ['GITHUB_OUTPUT'], 'a', encoding='utf-8') as gho: + gho.write(f"params={params!s}\n") print("Parameters:") print(params) @@ -114,6 +118,7 @@ jobs: for system in systems for version in (versions if system != 'msys2' else ['3.10']) ] - print(f'::set-output name=python_jobs::{jobs!s}') + with open(environ['GITHUB_OUTPUT'], 'a', encoding='utf-8') as gho: + gho.write(f"python_jobs={jobs!s}\n") print("Python jobs:") print(jobs) diff --git a/.github/workflows/Release.yml b/.github/workflows/Release.yml index cae3b0b..6d82182 100644 --- a/.github/workflows/Release.yml +++ b/.github/workflows/Release.yml @@ -39,9 +39,11 @@ jobs: RELEASE_VERSION=${GIT_TAG#v} RELEASE_DATETIME="$(date --utc '+%d.%m.%Y - %H:%M:%S')" # write to step outputs - echo ::set-output name=gitTag::${GIT_TAG} - echo ::set-output name=version::${RELEASE_VERSION} - echo ::set-output name=datetime::${RELEASE_DATETIME} + cat >> "$GITHUB_OUTPUT" << EOF + gitTag=${GIT_TAG} + version=${RELEASE_VERSION} + datetime=${RELEASE_DATETIME} + EOF - name: 📑 Create Release Page id: createReleasePage From 57a0827b141c9cd8a1218b6e921f3bbf6ce69f8d Mon Sep 17 00:00:00 2001 From: Unai Martinez-Corral Date: Mon, 7 Nov 2022 22:39:52 +0000 Subject: [PATCH 04/12] update actions/checkout to v3 --- .github/workflows/BuildTheDocs.yml | 2 +- .github/workflows/CoverageCollection.yml | 2 +- .github/workflows/Package.yml | 2 +- .github/workflows/PublishTestResults.yml | 2 +- .github/workflows/PublishToGitHubPages.yml | 2 +- .github/workflows/StaticTypeCheck.yml | 2 +- .github/workflows/TestReleaser.yml | 6 +++--- .github/workflows/UnitTesting.yml | 2 +- .github/workflows/VerifyDocs.yml | 2 +- 9 files changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/workflows/BuildTheDocs.yml b/.github/workflows/BuildTheDocs.yml index 5d49b03..cdfcd3d 100644 --- a/.github/workflows/BuildTheDocs.yml +++ b/.github/workflows/BuildTheDocs.yml @@ -38,7 +38,7 @@ jobs: steps: - name: ⏬ Checkout repository - uses: actions/checkout@v2 + uses: actions/checkout@v3 - name: 🛳️ Build documentation uses: buildthedocs/btd@v0 diff --git a/.github/workflows/CoverageCollection.yml b/.github/workflows/CoverageCollection.yml index 7161a39..6993d43 100644 --- a/.github/workflows/CoverageCollection.yml +++ b/.github/workflows/CoverageCollection.yml @@ -62,7 +62,7 @@ jobs: steps: - name: ⏬ Checkout repository - uses: actions/checkout@v2 + uses: actions/checkout@v3 - name: 🐍 Setup Python ${{ inputs.python_version }} uses: actions/setup-python@v2 diff --git a/.github/workflows/Package.yml b/.github/workflows/Package.yml index b16f2ca..e4187fd 100644 --- a/.github/workflows/Package.yml +++ b/.github/workflows/Package.yml @@ -48,7 +48,7 @@ jobs: steps: - name: ⏬ Checkout repository - uses: actions/checkout@v2 + uses: actions/checkout@v3 - name: 🐍 Setup Python ${{ inputs.python_version }} uses: actions/setup-python@v2 diff --git a/.github/workflows/PublishTestResults.yml b/.github/workflows/PublishTestResults.yml index 5844e33..50ed476 100644 --- a/.github/workflows/PublishTestResults.yml +++ b/.github/workflows/PublishTestResults.yml @@ -39,7 +39,7 @@ jobs: steps: - name: ⏬ Checkout repository - uses: actions/checkout@v2 + uses: actions/checkout@v3 - name: Download Artifacts uses: actions/download-artifact@v2 diff --git a/.github/workflows/PublishToGitHubPages.yml b/.github/workflows/PublishToGitHubPages.yml index 57ce6ec..75f6511 100644 --- a/.github/workflows/PublishToGitHubPages.yml +++ b/.github/workflows/PublishToGitHubPages.yml @@ -48,7 +48,7 @@ jobs: steps: - name: ⏬ Checkout repository - uses: actions/checkout@v2 + uses: actions/checkout@v3 - name: 📥 Download artifacts '${{ inputs.doc }}' from 'BuildTheDocs' job uses: actions/download-artifact@v2 diff --git a/.github/workflows/StaticTypeCheck.yml b/.github/workflows/StaticTypeCheck.yml index 55568c9..abc1766 100644 --- a/.github/workflows/StaticTypeCheck.yml +++ b/.github/workflows/StaticTypeCheck.yml @@ -57,7 +57,7 @@ jobs: steps: - name: ⏬ Checkout repository - uses: actions/checkout@v2 + uses: actions/checkout@v3 - name: 🐍 Setup Python ${{ inputs.python_version }} uses: actions/setup-python@v2 diff --git a/.github/workflows/TestReleaser.yml b/.github/workflows/TestReleaser.yml index e1749e5..4311548 100644 --- a/.github/workflows/TestReleaser.yml +++ b/.github/workflows/TestReleaser.yml @@ -45,7 +45,7 @@ jobs: env: DOCKER_BUILDKIT: 1 steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - name: Build container image run: docker build -t ghcr.io/pytooling/releaser -f releaser/Dockerfile releaser @@ -62,7 +62,7 @@ jobs: Composite: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - run: echo "Build some tool and generate some (versioned) artifacts" > artifact-$(date -u +"%Y-%m-%dT%H-%M-%SZ").txt @@ -122,7 +122,7 @@ jobs: - Composite runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - run: echo "Build some tool and generate some (versioned) artifacts" > artifact-$(date -u +"%Y-%m-%dT%H-%M-%SZ").txt diff --git a/.github/workflows/UnitTesting.yml b/.github/workflows/UnitTesting.yml index db4375c..48860df 100644 --- a/.github/workflows/UnitTesting.yml +++ b/.github/workflows/UnitTesting.yml @@ -76,7 +76,7 @@ jobs: steps: - name: ⏬ Checkout repository - uses: actions/checkout@v2 + uses: actions/checkout@v3 - name: '🟦 Setup MSYS2' if: matrix.system == 'msys2' diff --git a/.github/workflows/VerifyDocs.yml b/.github/workflows/VerifyDocs.yml index 45b8f23..e33d958 100644 --- a/.github/workflows/VerifyDocs.yml +++ b/.github/workflows/VerifyDocs.yml @@ -39,7 +39,7 @@ jobs: steps: - name: ⏬ Checkout repository - uses: actions/checkout@v2 + uses: actions/checkout@v3 - name: 🐍 Setup Python uses: actions/setup-python@v2 From c2c2516ec85910d9e0500d9ac98e3038dca6ddd9 Mon Sep 17 00:00:00 2001 From: Unai Martinez-Corral Date: Mon, 7 Nov 2022 22:41:35 +0000 Subject: [PATCH 05/12] update actions/setup-python to v4 --- .github/workflows/CoverageCollection.yml | 2 +- .github/workflows/Package.yml | 2 +- .github/workflows/PublishOnPyPI.yml | 2 +- .github/workflows/StaticTypeCheck.yml | 2 +- .github/workflows/UnitTesting.yml | 2 +- .github/workflows/VerifyDocs.yml | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/CoverageCollection.yml b/.github/workflows/CoverageCollection.yml index 6993d43..8b91184 100644 --- a/.github/workflows/CoverageCollection.yml +++ b/.github/workflows/CoverageCollection.yml @@ -65,7 +65,7 @@ jobs: uses: actions/checkout@v3 - name: 🐍 Setup Python ${{ inputs.python_version }} - uses: actions/setup-python@v2 + uses: actions/setup-python@v4 with: python-version: ${{ inputs.python_version }} diff --git a/.github/workflows/Package.yml b/.github/workflows/Package.yml index e4187fd..71bfbf2 100644 --- a/.github/workflows/Package.yml +++ b/.github/workflows/Package.yml @@ -51,7 +51,7 @@ jobs: uses: actions/checkout@v3 - name: 🐍 Setup Python ${{ inputs.python_version }} - uses: actions/setup-python@v2 + uses: actions/setup-python@v4 with: python-version: ${{ inputs.python_version }} diff --git a/.github/workflows/PublishOnPyPI.yml b/.github/workflows/PublishOnPyPI.yml index 1475375..097e74c 100644 --- a/.github/workflows/PublishOnPyPI.yml +++ b/.github/workflows/PublishOnPyPI.yml @@ -58,7 +58,7 @@ jobs: path: dist/ - name: 🐍 Setup Python ${{ inputs.python_version }} - uses: actions/setup-python@v2 + uses: actions/setup-python@v4 with: python-version: ${{ inputs.python_version }} diff --git a/.github/workflows/StaticTypeCheck.yml b/.github/workflows/StaticTypeCheck.yml index abc1766..85fb713 100644 --- a/.github/workflows/StaticTypeCheck.yml +++ b/.github/workflows/StaticTypeCheck.yml @@ -60,7 +60,7 @@ jobs: uses: actions/checkout@v3 - name: 🐍 Setup Python ${{ inputs.python_version }} - uses: actions/setup-python@v2 + uses: actions/setup-python@v4 with: python-version: ${{ inputs.python_version }} diff --git a/.github/workflows/UnitTesting.yml b/.github/workflows/UnitTesting.yml index 48860df..31dbc75 100644 --- a/.github/workflows/UnitTesting.yml +++ b/.github/workflows/UnitTesting.yml @@ -88,7 +88,7 @@ jobs: - name: 🐍 Setup Python ${{ matrix.python }} if: matrix.system != 'msys2' - uses: actions/setup-python@v2 + uses: actions/setup-python@v4 with: python-version: ${{ matrix.python }} diff --git a/.github/workflows/VerifyDocs.yml b/.github/workflows/VerifyDocs.yml index e33d958..18c0ee4 100644 --- a/.github/workflows/VerifyDocs.yml +++ b/.github/workflows/VerifyDocs.yml @@ -42,7 +42,7 @@ jobs: uses: actions/checkout@v3 - name: 🐍 Setup Python - uses: actions/setup-python@v2 + uses: actions/setup-python@v4 with: python-version: ${{ inputs.python_version }} From bbcfd70907d88c76f019df27fb2e9ec84177db07 Mon Sep 17 00:00:00 2001 From: Unai Martinez-Corral Date: Mon, 7 Nov 2022 22:44:12 +0000 Subject: [PATCH 06/12] update actions/upload-artifact to v3 --- .github/workflows/BuildTheDocs.yml | 2 +- .github/workflows/CoverageCollection.yml | 2 +- .github/workflows/Package.yml | 2 +- .github/workflows/StaticTypeCheck.yml | 2 +- .github/workflows/UnitTesting.yml | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/BuildTheDocs.yml b/.github/workflows/BuildTheDocs.yml index cdfcd3d..d223e99 100644 --- a/.github/workflows/BuildTheDocs.yml +++ b/.github/workflows/BuildTheDocs.yml @@ -46,7 +46,7 @@ jobs: skip-deploy: true - name: 📤 Upload 'documentation' artifacts - uses: actions/upload-artifact@master + uses: actions/upload-artifact@v3 with: name: ${{ inputs.artifact }} path: doc/_build/html diff --git a/.github/workflows/CoverageCollection.yml b/.github/workflows/CoverageCollection.yml index 8b91184..c307bca 100644 --- a/.github/workflows/CoverageCollection.yml +++ b/.github/workflows/CoverageCollection.yml @@ -134,7 +134,7 @@ jobs: - name: 📤 Upload 'Coverage Report' artifact continue-on-error: true - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: ${{ inputs.artifact }} path: ${{ steps.getVariables.outputs.coverage_report_html_directory }} diff --git a/.github/workflows/Package.yml b/.github/workflows/Package.yml index 71bfbf2..1edc84b 100644 --- a/.github/workflows/Package.yml +++ b/.github/workflows/Package.yml @@ -102,7 +102,7 @@ jobs: - name: 📤 Upload wheel artifact - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: ${{ inputs.artifact }} path: dist/ diff --git a/.github/workflows/StaticTypeCheck.yml b/.github/workflows/StaticTypeCheck.yml index 85fb713..c18f7a0 100644 --- a/.github/workflows/StaticTypeCheck.yml +++ b/.github/workflows/StaticTypeCheck.yml @@ -76,7 +76,7 @@ jobs: - name: 📤 Upload 'Static Typing Report' artifact if: ${{ inputs.artifact != '' }} continue-on-error: true - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: ${{ inputs.artifact }} path: ${{ inputs.report }} diff --git a/.github/workflows/UnitTesting.yml b/.github/workflows/UnitTesting.yml index 31dbc75..06a86bf 100644 --- a/.github/workflows/UnitTesting.yml +++ b/.github/workflows/UnitTesting.yml @@ -124,7 +124,7 @@ jobs: - name: 📤 Upload 'TestReport.xml' artifact if: inputs.artifact != '' - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: ${{ inputs.artifact }}-${{ matrix.system }}-${{ matrix.python }} path: TestReport.xml From bc41308f300f5429b33a15371d2530603a6a63c3 Mon Sep 17 00:00:00 2001 From: Unai Martinez-Corral Date: Mon, 7 Nov 2022 22:45:21 +0000 Subject: [PATCH 07/12] update actions/download-artifact to v3 --- .github/workflows/PublishOnPyPI.yml | 2 +- .github/workflows/PublishTestResults.yml | 2 +- .github/workflows/PublishToGitHubPages.yml | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/PublishOnPyPI.yml b/.github/workflows/PublishOnPyPI.yml index 097e74c..96a6cfa 100644 --- a/.github/workflows/PublishOnPyPI.yml +++ b/.github/workflows/PublishOnPyPI.yml @@ -52,7 +52,7 @@ jobs: steps: - name: 📥 Download artifacts '${{ inputs.artifact }}' from 'Package' job - uses: actions/download-artifact@v2 + uses: actions/download-artifact@v3 with: name: ${{ inputs.artifact }} path: dist/ diff --git a/.github/workflows/PublishTestResults.yml b/.github/workflows/PublishTestResults.yml index 50ed476..1d5bdb6 100644 --- a/.github/workflows/PublishTestResults.yml +++ b/.github/workflows/PublishTestResults.yml @@ -42,7 +42,7 @@ jobs: uses: actions/checkout@v3 - name: Download Artifacts - uses: actions/download-artifact@v2 + uses: actions/download-artifact@v3 with: path: artifacts diff --git a/.github/workflows/PublishToGitHubPages.yml b/.github/workflows/PublishToGitHubPages.yml index 75f6511..e323193 100644 --- a/.github/workflows/PublishToGitHubPages.yml +++ b/.github/workflows/PublishToGitHubPages.yml @@ -51,21 +51,21 @@ jobs: uses: actions/checkout@v3 - name: 📥 Download artifacts '${{ inputs.doc }}' from 'BuildTheDocs' job - uses: actions/download-artifact@v2 + uses: actions/download-artifact@v3 with: name: ${{ inputs.doc }} path: public - name: 📥 Download artifacts '${{ inputs.coverage }}' from 'Coverage' job if: ${{ inputs.coverage != '' }} - uses: actions/download-artifact@v2 + uses: actions/download-artifact@v3 with: name: ${{ inputs.coverage }} path: public/coverage - name: 📥 Download artifacts '${{ inputs.typing }}' from 'StaticTypeCheck' job if: ${{ inputs.typing != '' }} - uses: actions/download-artifact@v2 + uses: actions/download-artifact@v3 with: name: ${{ inputs.typing }} path: public/typing From b12b2d65be0228d70207de0e5fe15552b9f7d355 Mon Sep 17 00:00:00 2001 From: Unai Martinez-Corral Date: Mon, 7 Nov 2022 23:25:55 +0000 Subject: [PATCH 08/12] update geekyeggo/delete-artifact to v2 --- .github/workflows/ArtifactCleanUp.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ArtifactCleanUp.yml b/.github/workflows/ArtifactCleanUp.yml index 1ddff51..3b4dd9d 100644 --- a/.github/workflows/ArtifactCleanUp.yml +++ b/.github/workflows/ArtifactCleanUp.yml @@ -45,12 +45,12 @@ jobs: - name: 🗑️ Delete package Artifacts if: ${{ ! startsWith(github.ref, 'refs/tags') }} - uses: geekyeggo/delete-artifact@v1 + uses: geekyeggo/delete-artifact@v2 with: name: ${{ inputs.package }} - name: 🗑️ Delete remaining Artifacts if: ${{ inputs.remaining != '' }} - uses: geekyeggo/delete-artifact@v1 + uses: geekyeggo/delete-artifact@v2 with: name: ${{ inputs.remaining }} From 27272d362caf9792968564fb752b452885312b33 Mon Sep 17 00:00:00 2001 From: Unai Martinez-Corral Date: Mon, 7 Nov 2022 23:29:06 +0000 Subject: [PATCH 09/12] update codecov/codecov-action to v2 --- .github/workflows/CoverageCollection.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/CoverageCollection.yml b/.github/workflows/CoverageCollection.yml index c307bca..746d3e7 100644 --- a/.github/workflows/CoverageCollection.yml +++ b/.github/workflows/CoverageCollection.yml @@ -143,7 +143,7 @@ jobs: - name: 📊 Publish coverage at CodeCov continue-on-error: true - uses: codecov/codecov-action@v1 + uses: codecov/codecov-action@v2 with: file: ${{ steps.getVariables.outputs.coverage_report_xml }} flags: unittests From 47ef801713b593fbd13d74e7b708355edeb87170 Mon Sep 17 00:00:00 2001 From: Unai Martinez-Corral Date: Mon, 7 Nov 2022 23:41:59 +0000 Subject: [PATCH 10/12] update codecov/codecov-action to v3 --- .github/workflows/CoverageCollection.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/CoverageCollection.yml b/.github/workflows/CoverageCollection.yml index 746d3e7..d5c3757 100644 --- a/.github/workflows/CoverageCollection.yml +++ b/.github/workflows/CoverageCollection.yml @@ -143,9 +143,9 @@ jobs: - name: 📊 Publish coverage at CodeCov continue-on-error: true - uses: codecov/codecov-action@v2 + uses: codecov/codecov-action@v3 with: - file: ${{ steps.getVariables.outputs.coverage_report_xml }} + files: ${{ steps.getVariables.outputs.coverage_report_xml }} flags: unittests env_vars: PYTHON From 9faa1459c99387fdfedd1dd54a43345b166cb178 Mon Sep 17 00:00:00 2001 From: Unai Martinez-Corral Date: Tue, 8 Nov 2022 03:06:50 +0100 Subject: [PATCH 11/12] with-post-step: use option 'shell: true' by default and do not split args This fixes a breaking change introduced in #46. 'exec' executes commands on the shell by default, while 'spawn' does not. --- with-post-step/main.js | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/with-post-step/main.js b/with-post-step/main.js index 45caf18..107ec21 100644 --- a/with-post-step/main.js +++ b/with-post-step/main.js @@ -27,11 +27,8 @@ const { spawn } = require("child_process"); const fs = require('fs'); -function run(cmdline) { - var args = cmdline.split(" "); - const cmd = args.shift(); - - const subprocess = spawn(cmd, args, { stdio: "inherit" }); +function run(cmd) { + const subprocess = spawn(cmd, { stdio: "inherit", shell: true }); subprocess.on("exit", (exitCode) => { process.exitCode = exitCode; }); From decf16ff8f2b8699ed91f58f71120b8d2543b011 Mon Sep 17 00:00:00 2001 From: Unai Martinez-Corral Date: Tue, 8 Nov 2022 03:19:28 +0100 Subject: [PATCH 12/12] with-post-step: update copyright header --- with-post-step/main.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/with-post-step/main.js b/with-post-step/main.js index 107ec21..1a9c3f0 100644 --- a/with-post-step/main.js +++ b/with-post-step/main.js @@ -3,7 +3,8 @@ * Unai Martinez-Corral * * * * ================================================================================================================== * - * Copyright 2021 Unai Martinez-Corral * + * Copyright 2021-2022 Unai Martinez-Corral * + * Copyright 2022 Unai Martinez-Corral * * * * Licensed under the Apache License, Version 2.0 (the "License"); * * you may not use this file except in compliance with the License. *