Don't use "secrets: inherit"!

This commit is contained in:
Patrick Lehmann
2025-05-04 11:21:05 +02:00
parent 68357fddd8
commit bdf8239a73
3 changed files with 20 additions and 17 deletions

View File

@@ -96,23 +96,23 @@ on:
codecov: codecov:
description: 'Publish merged coverage and unittest reports to Codecov.' description: 'Publish merged coverage and unittest reports to Codecov.'
required: false required: false
default: false default: 'false'
type: boolean type: string
codacy: codacy:
description: 'Publish merged coverage report to Codacy.' description: 'Publish merged coverage report to Codacy.'
required: false required: false
default: false default: 'false'
type: boolean type: string
dorny: dorny:
description: 'Publish merged unittest report via Dorny Test-Reporter.' description: 'Publish merged unittest report via Dorny Test-Reporter.'
required: false required: false
default: false default: 'false'
type: boolean type: string
cleanup: cleanup:
description: 'Cleanup artifacts afterwards.' description: 'Cleanup artifacts afterwards.'
required: false required: false
default: true default: 'true'
type: boolean type: string
secrets: secrets:
PYPI_TOKEN: PYPI_TOKEN:
description: "Token for pushing releases to PyPI." description: "Token for pushing releases to PyPI."
@@ -194,7 +194,6 @@ jobs:
with: with:
python_version: ${{ needs.UnitTestingParams.outputs.python_version }} python_version: ${{ needs.UnitTestingParams.outputs.python_version }}
directory: ${{ needs.ConfigParams.outputs.package_directory }} directory: ${{ needs.ConfigParams.outputs.package_directory }}
# fail_below: 70
Package: Package:
uses: pyTooling/Actions/.github/workflows/Package.yml@dev uses: pyTooling/Actions/.github/workflows/Package.yml@dev
@@ -234,7 +233,9 @@ jobs:
coverage_report_html_directory: ${{ needs.ConfigParams.outputs.coverage_report_html_directory }} coverage_report_html_directory: ${{ needs.ConfigParams.outputs.coverage_report_html_directory }}
codecov: ${{ inputs.codecov }} codecov: ${{ inputs.codecov }}
codacy: ${{ inputs.codacy }} codacy: ${{ inputs.codacy }}
secrets: inherit secrets:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
CODACY_TOKEN: ${{ secrets.CODACY_TOKEN }}
PublishTestResults: PublishTestResults:
uses: pyTooling/Actions/.github/workflows/PublishTestResults.yml@dev uses: pyTooling/Actions/.github/workflows/PublishTestResults.yml@dev
@@ -248,7 +249,8 @@ jobs:
merged_junit_artifact: ${{ fromJson(needs.UnitTestingParams.outputs.artifact_names).unittesting_xml }} merged_junit_artifact: ${{ fromJson(needs.UnitTestingParams.outputs.artifact_names).unittesting_xml }}
dorny: ${{ inputs.dorny }} dorny: ${{ inputs.dorny }}
codecov: ${{ inputs.codecov }} codecov: ${{ inputs.codecov }}
secrets: inherit secrets:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
# VerifyDocs: # VerifyDocs:
# uses: pyTooling/Actions/.github/workflows/VerifyDocs.yml@dev # uses: pyTooling/Actions/.github/workflows/VerifyDocs.yml@dev
@@ -279,7 +281,7 @@ jobs:
- UnitTestingParams - UnitTestingParams
- PublishCoverageResults - PublishCoverageResults
- PublishTestResults - PublishTestResults
if: ${{ inputs.cleanup }} if: inputs.cleanup == 'true'
with: with:
sqlite_coverage_artifacts_prefix: ${{ fromJson(needs.UnitTestingParams.outputs.artifact_names).codecoverage_sqlite }}- sqlite_coverage_artifacts_prefix: ${{ fromJson(needs.UnitTestingParams.outputs.artifact_names).codecoverage_sqlite }}-
xml_unittest_artifacts_prefix: ${{ fromJson(needs.UnitTestingParams.outputs.artifact_names).unittesting_xml }}- xml_unittest_artifacts_prefix: ${{ fromJson(needs.UnitTestingParams.outputs.artifact_names).unittesting_xml }}-
@@ -354,7 +356,8 @@ jobs:
python_version: ${{ needs.UnitTestingParams.outputs.python_version }} python_version: ${{ needs.UnitTestingParams.outputs.python_version }}
requirements: -r dist/requirements.txt requirements: -r dist/requirements.txt
artifact: ${{ fromJson(needs.UnitTestingParams.outputs.artifact_names).package_all }} artifact: ${{ fromJson(needs.UnitTestingParams.outputs.artifact_names).package_all }}
secrets: inherit secrets:
PYPI_TOKEN: ${{ secrets.PYPI_TOKEN }}
ArtifactCleanUp: ArtifactCleanUp:
uses: pyTooling/Actions/.github/workflows/ArtifactCleanUp.yml@dev uses: pyTooling/Actions/.github/workflows/ArtifactCleanUp.yml@dev
@@ -369,7 +372,7 @@ jobs:
- PublishToGitHubPages - PublishToGitHubPages
# - PublishOnPyPI # - PublishOnPyPI
- IntermediateCleanUp - IntermediateCleanUp
if: ${{ inputs.cleanup }} if: inputs.cleanup == 'true'
with: with:
package: ${{ fromJson(needs.UnitTestingParams.outputs.artifact_names).package_all }} package: ${{ fromJson(needs.UnitTestingParams.outputs.artifact_names).package_all }}
remaining: | remaining: |

View File

@@ -225,10 +225,10 @@ jobs:
if [[ "${{ steps.codecov.outcome }}" == "failure" ]]; then if [[ "${{ steps.codecov.outcome }}" == "failure" ]]; then
printf "::error title=%s::%s\n" "Publish Code Coverage Results / Codecov" "Failed to publish code coverage results." printf "::error title=%s::%s\n" "Publish Code Coverage Results / Codecov" "Failed to publish code coverage results."
else else
printf "Codecov: No errors to report." printf "Codecov: No errors to report.\n"
fi fi
if [[ "${{ steps.codacy.outcome }}" == "failure" ]]; then if [[ "${{ steps.codacy.outcome }}" == "failure" ]]; then
printf "::error title=%s::%s\n" "Publish Code Coverage Results / Codacy" "Failed to publish code coverage results." printf "::error title=%s::%s\n" "Publish Code Coverage Results / Codacy" "Failed to publish code coverage results."
else else
printf "Codacy: No errors to report." printf "Codacy: No errors to report.\n"
fi fi

View File

@@ -145,7 +145,7 @@ jobs:
if [[ "${{ steps.codecov.outcome }}" == "failure" ]]; then if [[ "${{ steps.codecov.outcome }}" == "failure" ]]; then
printf "::error title=%s::%s\n" "Publish Unit Test Results / Codecov" "Failed to publish unittest results." printf "::error title=%s::%s\n" "Publish Unit Test Results / Codecov" "Failed to publish unittest results."
else else
printf "Codecov: No errors to report." printf "Codecov: No errors to report.\n"
fi fi
- name: 📤 Upload merged 'JUnit Test Summary' artifact - name: 📤 Upload merged 'JUnit Test Summary' artifact