Add missing version check to test_harness (#81 )

#79 introduced a version requirement for annotations for installing the dependencies but not for the code that adds the annotations, resulting in a dependency error for certain versions. Fixes #80
Restrict annotation functionality to versions of Julia it works on (#79 )
2026-02-12 11:06:54 +08:00 · 2023-04-07 14:51:09 +02:00 · 2023-04-02 23:23:43 +02:00 · 2023-03-22 23:17:43 +01:00
3 changed files with 7 additions and 4 deletions
--- a/README.md
+++ b/README.md
@@ -38,13 +38,15 @@ jobs:
          arch: ${{ matrix.julia-arch }}
      - uses: julia-actions/julia-buildpkg@v1
      - uses: julia-actions/julia-runtest@v1
-        with:
-          annotate: true
+        # with:
+        #   annotate: true
 ```

 You can add this workflow to your repository by placing it in a file called `test.yml` in the folder `.github/workflows/`. [More info here](https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions).

 Here, setting `annotate: true` causes GitHub "annotations" to appear when reviewing the PR, pointing to failing tests, if any.
+This functionality is only enabled on Julia 1.8 (even if `annotate` is set to `true`), since currently it does not work on other Julia versions (see #76).
+
 By default, `annotate` is set to false, but that may change in future releases of this action.
 ### Prefixing the Julia command

--- a/action.yml
+++ b/action.yml
@@ -41,7 +41,8 @@ runs:
      shell: bash
    - name: Install dependencies in their own (shared) environment
      run: |
-        if VERSION > v"1.8pre"
+        # Functionality only currently works on a narrow range of Julia versions... see #76
+        if v"1.8pre" < VERSION < v"1.9.0-beta3"
          using Pkg
          Pkg.activate("tests-logger-env"; shared=true)
          Pkg.add(Pkg.PackageSpec(name="GitHubActions", version="0.1"))
--- a/test_harness.jl
+++ b/test_harness.jl
@@ -4,7 +4,7 @@ kwargs = Kwargs.kwargs(; coverage=ENV["COVERAGE"],
                         force_latest_compatible_version=ENV["FORCE_LATEST_COMPATIBLE_VERSION"],
                         julia_args=[string("--check-bounds=", ENV["CHECK_BOUNDS"])])

-if parse(Bool, ENV["ANNOTATE"]) && VERSION > v"1.8pre"
+if parse(Bool, ENV["ANNOTATE"]) && v"1.8pre" < VERSION < v"1.9.0-beta3"
    push!(LOAD_PATH, "@tests-logger-env") # access dependencies
    using GitHubActions, Logging
    global_logger(GitHubActionsLogger())
Author	SHA1	Message	Date
Sascha Mann	79a7e10088	Add missing version check to test_harness (#81 ) #79 introduced a version requirement for annotations for installing the dependencies but not for the code that adds the annotations, resulting in a dependency error for certain versions. Fixes #80	2023-04-07 14:51:09 +02:00
Eric Hanson	1aec431e02	Restrict annotation functionality to versions of Julia it works on (#79 ) * Restrict annotation functionality to versions of Julia it works on see #76 * Update README.md	2023-04-02 23:23:43 +02:00
Sascha Mann	4867b265f3	Add warning about annotate (#77 )	2023-03-22 23:17:43 +01:00