Add production dependencies & build

README.md

@@ -11,6 +11,7 @@ This action sets up a Julia environment for use in actions by downloading a spec
   - [Julia Versions](#julia-versions)
   - [Matrix Testing](#matrix-testing)
 - [Versioning](#versioning)
+- [Future plans & ideas](#future-plans--ideas)
 - [Licence info](#licence-info)
 
 ## Usage
@@ -24,7 +25,7 @@ You can find a list of example workflows making use of this action here: [julia-
 ```yaml
 steps:
 - uses: actions/checkout@v1.0.0
-- uses: julia-actions/setup-julia@v1
+- uses: julia-actions/setup-julia@v0.2
   with:
     version: 1.0.4
 - run: julia -e 'println("Hello, World!")'
@@ -41,7 +42,6 @@ You can either specify specific Julia versions or version ranges. If you specify
 - `1.2.0` is a valid semver version. The action will try to download exactly this version. If it's not available, the build step will fail.
 - `1.0` is a version range that will match the highest available Julia version that starts with `1.0`, e.g. `1.0.5`.
 - `^1.3.0-rc1` is a caret version range that includes preleases. It matches all versions `≥ 1.3.0-rc1` and `< 1.4.0`.
-- `nightly` will install the latest nightly build.
 
 Internally the action uses node's semver package to resolve version ranges. Its [documentation](https://github.com/npm/node-semver#advanced-range-syntax) contains more details on the version range syntax.
 
@@ -65,7 +65,7 @@ jobs:
     steps:
       - uses: actions/checkout@v1.0.0
       - name: "Set up Julia"
-        uses: julia-actions/setup-julia@v1
+        uses: julia-actions/setup-julia@v0.2
         with:
           version: ${{ matrix.julia-version }}
       - run: julia -e 'println("Hello, World!")'
@@ -90,7 +90,7 @@ jobs:
     steps:
       - uses: actions/checkout@v1.0.0
       - name: "Set up Julia"
-        uses: julia-actions/setup-julia@v1
+        uses: julia-actions/setup-julia@v0.2
         with:
           version: ${{ matrix.julia-version }}
           arch: ${{ matrix.julia-arch }}
@@ -116,7 +116,7 @@ jobs:
     steps:
       - uses: actions/checkout@v1.0.0
       - name: "Set up Julia"
-        uses: julia-actions/setup-julia@v1
+        uses: julia-actions/setup-julia@v0.2
         with:
           version: ${{ matrix.julia-version }}
       - run: julia -e 'println("Hello, World!")'
@@ -141,5 +141,14 @@ steps:
   - uses: julia-actions/setup-julia@v0.1.0  # specific version tag
 ```
 
+## Future plans & ideas
+
+In no particular order:
+
+* Check if a cached version of Julia is available instead of installing it everytime CI runs ([waiting on GitHub to add proper caching](https://twitter.com/natfriedman/status/1164210683979812869))
+* Add support for nightly Julia builds.
+* Add CI script that checks if tags have been updated on release.
+* Hash and signature checks.
+
 ## Licence info
 Parts of this software have been derived from the `setup-go` [action](https://github.com/actions/setup-go) and the [TypeScript Action Template](https://github.com/actions/typescript-action), both released by GitHub under the MIT licence.

__tests__/main.test.ts

@@ -1,7 +1,5 @@
 import * as installer from '../src/installer'
 
-import * as semver from 'semver'
-
 const testVersions = ['v1.3.0-rc4', 'v1.3.0-rc3', 'v1.3.0-rc2', 'v1.0.5', 'v1.2.0', 'v1.3.0-rc1', 'v1.2.0-rc3', 'v1.3.0-alpha', 'v1.2.0-rc2', 'v1.2.0-rc1', 'v1.1.1', 'v1.0.4', 'v1.1.0', 'v1.1.0-rc2', 'v1.1.0-rc1', 'v1.0.3', 'v1.0.2', 'v1.0.1', 'v1.0.0']
 
 describe('installer tests', () => {
@@ -16,10 +14,6 @@ describe('installer tests', () => {
                 expect(await installer.getJuliaVersion(['v1.2.0', 'v1.3.0-alpha', 'v1.3.0-rc1', 'v1.3.0'], '1.3.0-alpha')).toEqual('1.3.0-alpha')
                 expect(await installer.getJuliaVersion([], '1.3.0-rc2')).toEqual('1.3.0-rc2')
             })
-            it('Doesn\'t change the version when given `nightly`', async () => {
-                expect(await installer.getJuliaVersion([], 'nightly')).toEqual('nightly')
-                expect(await installer.getJuliaVersion(testVersions, 'nightly')).toEqual('nightly')
-            })
         })
         describe('version ranges', () => {
             it('Chooses the highest available version that matches the input', async () => {
@@ -30,14 +24,4 @@ describe('installer tests', () => {
             })
         })
     })
-    describe('node-semver behaviour', () => {
-        describe('Windows installer change', () => {
-            it('Correctly understands >1.4.0', () => {
-                expect(semver.gtr('1.4.0-rc1', '1.3', {includePrerelease: true})).toBeTruthy()
-                expect(semver.gtr('1.4.0-DEV', '1.3', {includePrerelease: true})).toBeTruthy()
-                expect(semver.gtr('1.3.1', '1.3', {includePrerelease: true})).toBeFalsy()
-                expect(semver.gtr('1.3.2-rc1', '1.3', {includePrerelease: true})).toBeFalsy()
-            })
-        })
-    })
 })

bin/build-test-release

@@ -1,14 +0,0 @@
-#!/bin/sh
-
-branch_name="$(git symbolic-ref --short -q HEAD)"
-
-git checkout -B test/"$branch_name"
-
-npm install
-npm run build
-npm test
-npm prune --production
-
-sed -i 's/node_modules/!node_modules/g' .gitignore
-git add node_modules
-git commit -a -m "Add production dependencies & build"

lib/installer.js

@@ -32,10 +32,6 @@ function getJuliaVersion(availableReleases, versionInput) {
             // versionInput is a valid version, use it directly
             return versionInput;
         }
-        // nightlies
-        if (versionInput == 'nightly') {
-            return 'nightly';
-        }
         // Use the highest available version that matches versionInput
         let version = semver.maxSatisfying(availableReleases, versionInput);
         if (version == null) {
@@ -51,7 +47,9 @@ function getMajorMinorVersion(version) {
     return version.split('.').slice(0, 2).join('.');
 }
 function getDownloadURL(version, arch) {
+    const baseURL = 'https://julialang-s3.julialang.org/bin';
     let platform;
+    const versionDir = getMajorMinorVersion(version);
     if (osPlat === 'win32') { // Windows
         platform = 'winnt';
     }
@@ -67,14 +65,6 @@ function getDownloadURL(version, arch) {
     else {
         throw `Platform ${osPlat} is not supported`;
     }
-    // nightlies
-    if (version == 'nightly') {
-        const baseURL = 'https://julialangnightlies-s3.julialang.org/bin';
-        return `${baseURL}/${platform}/${arch}/${getFileName('latest', arch)}`;
-    }
-    // normal versions
-    const baseURL = 'https://julialang-s3.julialang.org/bin';
-    const versionDir = getMajorMinorVersion(version);
     return `${baseURL}/${platform}/${arch}/${versionDir}/${getFileName(version, arch)}`;
 }
 function getFileName(version, arch) {
@@ -91,12 +81,7 @@ function getFileName(version, arch) {
         ext = 'dmg';
     }
     else if (osPlat === 'linux') { // Linux
-        if (version == 'latest') { // nightly version
-            versionExt = arch == 'x64' ? '-linux64' : '-linux32';
-        }
-        else {
-            versionExt = arch == 'x64' ? '-linux-x86_64' : '-linux-i686';
-        }
+        versionExt = arch == 'x64' ? '-linux-x86_64' : '-linux-i686';
         ext = 'tar.gz';
     }
     else {
@@ -113,25 +98,15 @@ function installJulia(version, arch) {
         // Install it
         switch (osPlat) {
             case 'linux':
-                // tc.extractTar doesn't support stripping components, so we have to call tar manually
-                yield exec.exec('mkdir', [`${process.env.HOME}/julia`]);
-                yield exec.exec('tar', ['xf', juliaDownloadPath, '--strip-components=1', '-C', `${process.env.HOME}/julia`]);
-                return `${process.env.HOME}/julia`;
+                const juliaExtractedFolder = yield tc.extractTar(juliaDownloadPath);
+                return path.join(juliaExtractedFolder, `julia-${version}`);
             case 'win32':
                 const juliaInstallationPath = path.join('C:', 'Julia');
-                if (version == 'nightly' || semver.gtr(version, '1.3', { includePrerelease: true })) {
-                    // The installer changed in 1.4: https://github.com/JuliaLang/julia/blob/ef0c9108b12f3ae177c51037934351ffa703b0b5/NEWS.md#build-system-changes
-                    yield exec.exec('powershell', ['-Command', `Start-Process -FilePath ${juliaDownloadPath} -ArgumentList "/SILENT /dir=${juliaInstallationPath}" -NoNewWindow -Wait`]);
-                }
-                else {
-                    yield exec.exec('powershell', ['-Command', `Start-Process -FilePath ${juliaDownloadPath} -ArgumentList "/S /D=${juliaInstallationPath}" -NoNewWindow -Wait`]);
-                }
+                yield exec.exec('powershell', ['-Command', `Start-Process -FilePath ${juliaDownloadPath} -ArgumentList "/S /D=${juliaInstallationPath}" -NoNewWindow -Wait`]);
                 return juliaInstallationPath;
             case 'darwin':
                 yield exec.exec('hdiutil', ['attach', juliaDownloadPath]);
-                yield exec.exec('mkdir', [`${process.env.HOME}/julia`]);
-                yield exec.exec('/bin/bash', ['-c', `cp -a /Volumes/Julia-*/Julia-*.app/Contents/Resources/julia ${process.env.HOME}`]);
-                return `${process.env.HOME}/julia`;
+                return `/Volumes/Julia-${version}/Julia-${getMajorMinorVersion(version)}.app/Contents/Resources/julia`;
             default:
                 throw `Platform ${osPlat} is not supported`;
         }

src/installer.ts

@@ -21,11 +21,6 @@ export async function getJuliaVersion(availableReleases: string[], versionInput:
         return versionInput
     }
 
-    // nightlies
-    if (versionInput == 'nightly') {
-        return 'nightly'
-    }
-
     // Use the highest available version that matches versionInput
     let version = semver.maxSatisfying(availableReleases, versionInput)
     if (version == null) {
@@ -43,7 +38,9 @@ function getMajorMinorVersion(version: string): string {
 }
 
 function getDownloadURL(version: string, arch: string): string {
+    const baseURL = 'https://julialang-s3.julialang.org/bin'
     let platform: string
+    const versionDir = getMajorMinorVersion(version)
 
     if (osPlat === 'win32') { // Windows
         platform = 'winnt'
@@ -58,16 +55,6 @@ function getDownloadURL(version: string, arch: string): string {
         throw `Platform ${osPlat} is not supported`
     }
 
-    // nightlies
-    if (version == 'nightly') {
-        const baseURL = 'https://julialangnightlies-s3.julialang.org/bin'
-        return `${baseURL}/${platform}/${arch}/${getFileName('latest', arch)}`
-    }
-
-    // normal versions
-    const baseURL = 'https://julialang-s3.julialang.org/bin'
-    const versionDir = getMajorMinorVersion(version)
-
     return `${baseURL}/${platform}/${arch}/${versionDir}/${getFileName(version, arch)}`
 }
 
@@ -84,11 +71,7 @@ function getFileName(version: string, arch: string): string {
         versionExt = '-mac64'
         ext = 'dmg'
     } else if (osPlat === 'linux') { // Linux
-        if (version == 'latest') { // nightly version
-            versionExt = arch == 'x64' ? '-linux64' : '-linux32'
-        } else {
-            versionExt = arch == 'x64' ? '-linux-x86_64' : '-linux-i686'
-        }
+        versionExt = arch == 'x64' ? '-linux-x86_64' : '-linux-i686'
         ext = 'tar.gz'
     } else {
         throw `Platform ${osPlat} is not supported`
@@ -106,24 +89,15 @@ export async function installJulia(version: string, arch: string): Promise<strin
     // Install it
     switch (osPlat) {
         case 'linux':
-            // tc.extractTar doesn't support stripping components, so we have to call tar manually
-            await exec.exec('mkdir', [`${process.env.HOME}/julia`])
-            await exec.exec('tar', ['xf', juliaDownloadPath, '--strip-components=1', '-C', `${process.env.HOME}/julia`])
-            return `${process.env.HOME}/julia`
+            const juliaExtractedFolder = await tc.extractTar(juliaDownloadPath)
+            return path.join(juliaExtractedFolder, `julia-${version}`)
         case 'win32':
             const juliaInstallationPath = path.join('C:', 'Julia')
-            if (version == 'nightly' || semver.gtr(version, '1.3', {includePrerelease: true})) {
-                // The installer changed in 1.4: https://github.com/JuliaLang/julia/blob/ef0c9108b12f3ae177c51037934351ffa703b0b5/NEWS.md#build-system-changes
-                await exec.exec('powershell', ['-Command', `Start-Process -FilePath ${juliaDownloadPath} -ArgumentList "/SILENT /dir=${juliaInstallationPath}" -NoNewWindow -Wait`])
-            } else {
-                await exec.exec('powershell', ['-Command', `Start-Process -FilePath ${juliaDownloadPath} -ArgumentList "/S /D=${juliaInstallationPath}" -NoNewWindow -Wait`])
-            }
+            await exec.exec('powershell', ['-Command', `Start-Process -FilePath ${juliaDownloadPath} -ArgumentList "/S /D=${juliaInstallationPath}" -NoNewWindow -Wait`])
             return juliaInstallationPath
         case 'darwin':
             await exec.exec('hdiutil', ['attach', juliaDownloadPath])
-            await exec.exec('mkdir', [`${process.env.HOME}/julia`])
-            await exec.exec('/bin/bash', ['-c', `cp -a /Volumes/Julia-*/Julia-*.app/Contents/Resources/julia ${process.env.HOME}`])
-            return `${process.env.HOME}/julia`
+            return `/Volumes/Julia-${version}/Julia-${getMajorMinorVersion(version)}.app/Contents/Resources/julia`
         default:
             throw `Platform ${osPlat} is not supported`
     }